Warm tip: This article is reproduced from stackoverflow.com, please click
arrays electron javascript scope

array.length is zero, but the array has elements in it

发布于 2021-03-07 11:32:52

I'm currently in the process practicing using electron, but I'm quite new with javascript and I've come across a problem which has me completely baffled. I have the following code:

    function getPaths() {
      var dirPath = document.getElementById("mdir").innerHTML;
      var filePaths = [];
      fs.readdir(dirPath, function(err, dir) {
        for(var i = 0, l = dir.length; i < l; i++) {
          var filePath = dir[i];
          filePaths.push(dirPath + "/" + filePath);
        }
      });
      console.log(filePaths);
      console.log(filePaths.length);
    }

Which is supposed to look into a directory defined by dirPath, then it loops through and obtains the full path of all files in that directory. It appends them to an array, and then at the bottom, it logs the array to the console, followed by the length of the array. What is baffling me is that given that code, the array logs to the console like expected, but then the console logs zero as the length. My current thinking is that it's got something to do with scope, but that doesn't make sense because I'm declaring the array, filePaths in the function above the one that's running. Unless I've missed something. Could anyone point out what I'm doing wrong?

Questioner
Taira
Viewed
0
分享
ibrahim mahrir 2018-05-07 22:38

readdir is asynchronous. It won't get the result right away. You should log the filePaths inside the callback. The only reason why the console show the value is because the console evaluate the array when you unfold it.

When you press the little arrow on the left, put the mouse on the i box on the right. What happen is that the console keeps a reference to the array, so when the user unfold the array it then show what its current value is. But when you log filePaths.length the array is empty because readdir didn't finish reading yet that's why you get 0. But by the time you open the console and press that arrow, readdir will already be done reading and the console will print the current value of the array (after it been filled).

enter image description here

Example to demonstrate the problem: (not a solution, it's just to understand what is really happening)

Try and run this code and see what happen:

var arr = [];
setTimeout(function() {
  arr.push(1, 2, 3);
}, 5000);
console.log(arr.length);
console.log(arr);

Here the array and it's length are both logged before the array is filled. The array will be filled after 5 seconds. So the output will be 0 and a string array[]. Now because arrays could have tons of data, the console won't show that data untill the user unfold the array. So what the console does is keep a reference to the array untill the user press unfold arrow. If you unfold the array before 5 seconds you see that the array is empty (not filled yet). If you wait untill the 5 seconds pass then unfold it, then you'll see that it's filled.

Note: Also, the line that get logged to the console (something like > Array(0)) is just a string representation of the object/array at the moment the log happens. It won't get updated if the object/array changes. So that also may seem confusing sometimes.

I hope it's clear now.

MaxZoom 1970-01-01 08:00:00

I would not recommend to use setTimeout function as the response time could vary significantly based on the directory content

ibrahim mahrir 1970-01-01 08:00:00

@MaxZoom I didn't suggest setTimeout as a solution! I just explained the OP's problem using a easy-to-understand example using setTimeout to emphasize on the asynchronousity of the problem!

Taira 1970-01-01 08:00:00

Ok, so if I've got this right, the reason why I'm not getting a value is because readdir is asynchronous. As a result, console.log() completes before the array has been built, and as a result it returns 0?

ibrahim mahrir 1970-01-01 08:00:00

@Taira exactly! readdir will just regester the callback to be called when the reading is done, and proceed to the next statement and execute it (pretty much the same of what happening with setTimeout))! If you want the synchronous version use readdirSync (but I wouldn't recommend it).

Taira 1970-01-01 08:00:00

Ok, that makes sense! I come from a background in Python, so this type of thing is quite foreign to me. One other question though: out of curiosity, why would readdirSync not be recommended?

Related issues

1
Getting .json is not a function on Promise.all w/fetch
2
Javascript for loop only giving one output
3
find array value that index matches another array values
4
React
5
Communication between two components using ReactJS
6
Figma Plugin: callback on file updated
7
indexof() partial match issue
8
React useState hook and submit in multi step form
9
How do i get this firebase data to use it outside the loop?
10
How to define a font size that scales with browser zoom level?